Modernise overloading pragma a little #23716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the version declaration into the package line. - Use v5.40 to get strict, warnings, and the module_true feature. - Make private sub lexical, it's unlikely to be used in darkpan. - Make use of subroutine signatures.
leonerd
approved these changes
Sep 17, 2025
Contributor
leonerd
left a comment
leonerd
left a comment
There was a problem hiding this comment.
LGTM
Thanks for making a start at this monumental effort. Hopefully we can encourage more folks to do more files like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes does not require a perldelta entry.